TokenType is 0 based according to LSP spec #964
Conversation
|
Hi @BoykoAlex , Is it correct that this is a similar change to the one done in the recent Xtext 2.34 (eclipse/xtext#2753, see changes to org.eclipse.xtext.ide/src/org/eclipse/xtext/ide/server/semantictokens/SemanticTokensService.java). Also, out of curiosity, are you using an Xtext-based language server, or have you discovered the issue with a different type of server? Regards |
| expectedTokens.add(Arrays.asList(0,0,4,1,0)); | ||
| expectedTokens.add(Arrays.asList(3,0,4,1,0)); | ||
| expectedTokens.add(Arrays.asList(0,9,7,1,0)); | ||
| expectedTokens.add(Arrays.asList(0,0,4,0,0)); |
There was a problem hiding this comment.
You need to increase as well the version number of the test plugin for the commit to be buildable.
|
@rubenporras yes, looks like it is the same kind of change to me. No, not using XText, at least at the moment. There are JPA Queries that are typically embedded in annotations inside Java code. Therefore, we decided to provide semantic highlighting for query strings inside Java annotations. This is implemented as part of the Spring Boot Language server. The clients are LSP4E and vscode-languageclient. The work is tracked by spring-projects/sts4#1114. I have to admit highlighting is somewhat unknown territory for me... so I had some additional questions here #965 |
No description provided.