Fix erratic test failure in DiagnosticsTest #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the erratic test failure `FileSystemException: The process cannot access the file because it is being used by another process seen` on Windows in `DiagnosticsTest#testDiagnosticsForMarkerUpdateAfterDeletedFile`: ``` org.eclipse.core.internal.resources.ResourceException: Problems encountered while deleting resources. at org.eclipse.core.internal.resources.Resource.delete(Resource.java:816) at org.eclipse.core.internal.resources.Resource.delete(Resource.java:772) at org.eclipse.lsp4e.test.diagnostics.DiagnosticsTest.testDiagnosticsForMarkerUpdateAfterDeletedFile(DiagnosticsTest.java:192) Contains: Could not delete 'D:\junit-workspace\DiagnoticsTest1714763955417\test1714763955426.lspt'. org.eclipse.core.runtime.CoreException: Could not delete: D:\junit-workspace\DiagnoticsTest1714763955417\test1714763955426.lspt. at org.eclipse.core.internal.filesystem.local.LocalFile.delete(LocalFile.java:161) at org.eclipse.core.internal.resources.ResourceTree.internalDeleteFile(ResourceTree.java:315) at org.eclipse.core.internal.resources.ResourceTree.standardDeleteFile(ResourceTree.java:801) at org.eclipse.core.internal.resources.Resource.unprotectedDelete(Resource.java:1826) at org.eclipse.core.internal.resources.Resource.delete(Resource.java:803) at org.eclipse.core.internal.resources.Resource.delete(Resource.java:772) at org.eclipse.lsp4e.test.diagnostics.DiagnosticsTest.testDiagnosticsForMarkerUpdateAfterDeletedFile(DiagnosticsTest.java:192) Caused by: java.nio.file.FileSystemException: D:\junit-workspace\DiagnoticsTest1714763955417\test1714763955426.lspt: The process cannot access the file because it is being used by another process at java.base/sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:92) at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103) at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:108) at java.base/sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:275) at java.base/sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(AbstractFileSystemProvider.java:110) at java.base/java.nio.file.Files.deleteIfExists(Files.java:1191) at org.eclipse.core.internal.filesystem.local.LocalFile.internalDelete(LocalFile.java:242) at org.eclipse.core.internal.filesystem.local.LocalFile.delete(LocalFile.java:159) ... 64 more ```
sebthom
force-pushed
the
cannot-delete-file
branch
from
8c10430
to
98c356a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the erratic test failure
FileSystemException: The process cannot access the file because it is being used by another processseen on Windows inDiagnosticsTest#testDiagnosticsForMarkerUpdateAfterDeletedFile: