LSP4Jakarta alignment with the LSP4MP code base #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the existing lsp4jakarta code base
mezarin
force-pushed
the
fullParityPOC
branch
from
c401260
to
027d547
Compare
turkeylurkey
changed the title
mrglavas
reviewed
Oct 13, 2023
...jakarta.jdt.core/src/main/java/org/eclipse/lsp4jakarta/jdt/core/java/AbtractJavaContext.java
Outdated
Show resolved
Hide resolved
mrglavas
approved these changes
Oct 16, 2023
…per classpath filtering upon dependency changes
turkeylurkey
requested changes
Oct 16, 2023
...java/org/eclipse/lsp4jakarta/jdt/core/java/codeaction/InsertAnnotationAttributeQuickFix.java
Show resolved
Hide resolved
...ava/org/eclipse/lsp4jakarta/jdt/core/java/codeaction/InsertAnnotationAttributesQuickFix.java
Show resolved
Hide resolved
...n/java/org/eclipse/lsp4jakarta/jdt/core/java/codeaction/InsertAnnotationMissingQuickFix.java
Show resolved
Hide resolved
...a/org/eclipse/lsp4jakarta/jdt/core/java/corrections/proposal/ImplementInterfaceProposal.java
Show resolved
Hide resolved
...ta.jdt.core/src/main/resources/org/eclipse/lsp4jakarta/jdt/core/messages/messages.properties
Show resolved
Hide resolved
turkeylurkey
approved these changes
Oct 17, 2023
This was referenced Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns LSP4Jakarta with the LSP4MP code base. This is part one in the process of abstracting a common component that could be used by multiple LSP implementations such as LSP4MP, LSP4Jakarta, and others.