Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show value of property when hovering key even when it isn't recognized #285

Closed
datho7561 opened this issue Aug 25, 2022 · 1 comment · Fixed by #293
Closed

Show value of property when hovering key even when it isn't recognized #285

datho7561 opened this issue Aug 25, 2022 · 1 comment · Fixed by #293
Assignees
@datho7561
Labels
hover properties-files Features supported in microprofile-config.properties
Milestone
0.6.0

Comments

@datho7561
Copy link
Contributor

Say we have a microprofile-config.properties file:

asdf=foo ${bar}
bar=${hjkl} World!
hjkl = Hello,

If the property asdf were defined somewhere in the application with @ConfigProperty, you can hover over the asdf before the =, and it will show the final resolved value. However, this is not supported for properties that aren't defined in the application. I think it could be helpful to show the final resolved value in these cases.
@rgrunber rgrunber added properties-files Features supported in microprofile-config.properties hover labels Aug 25, 2022
@datho7561
Copy link
Contributor Author

I'm interested in working on this

datho7561 added a commit to datho7561/lsp4mp that referenced this issue Sep 30, 2022
@datho7561
Show value when hovering unrecognized property
fe3ba86 
Closes eclipse#285

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Sep 30, 2022
Merged
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Sep 30, 2022
@datho7561
Show value when hovering unrecognized property
8365666 
Closes eclipse#285

Signed-off-by: David Thompson <davthomp@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 5, 2022
@datho7561 @angelozerr
Show value when hovering unrecognized property
5cf8de4 
Closes #285

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr added this to the 0.6.0 milestone Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
hover properties-files Features supported in microprofile-config.properties
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Show value when hovering unrecognized property datho7561/lsp4mp
3 participants
@rgrunber @angelozerr @datho7561