MicroProfileConfigASTValidator handles @ConfigProperties in a wrong way

[jeffmaury]

MicroProfileConfigASTValidator tries to locate @ConfigProperties but it uses only the simple class name and not the fully qualified class name.
As a result, it also works for Quarkus @ConfigProperties but it should located into the Quarkus specific part and it may wrongly process @ConfigProperties annotations from other packages.

[rgrunber]

When I look at

lsp4mp/microprofile.jdt/org.eclipse.lsp4mp.jdt.core/src/main/java/org/eclipse/lsp4mp/jdt/internal/config/java/MicroProfileConfigASTValidator.java

Line 109 in 8ccfef8

&& AnnotationUtils.isMatchAnnotation((NormalAnnotation) modifier, CONFIG_PROPERTIES_ANNOTATION)) {

it's using

lsp4mp/microprofile.jdt/org.eclipse.lsp4mp.jdt.core/src/main/java/org/eclipse/lsp4mp/jdt/core/MicroProfileConfigConstants.java

Line 41 in 8ccfef8

public static final String CONFIG_PROPERTIES_ANNOTATION = "org.eclipse.microprofile.config.inject.ConfigProperties";

, which is fully qualified.

I think quarkus-ls has a separate properties provider to handle ConfigProperties from that end also.

[jeffmaury]

Yes agree but if you go into isMatchAnnotation you will find that the annotation type name is ConfigProperties and not the fully qualified name
See my Eclipse debugging session:

[rgrunber]

Interesting, so immediately above that is line 186, which is AnnotationUtils.isMatchAnnotation(..)

lsp4mp/microprofile.jdt/org.eclipse.lsp4mp.jdt.core/src/main/java/org/eclipse/lsp4mp/jdt/core/utils/AnnotationUtils.java

Line 186 in 8ccfef8

return annotationName.endsWith(annotation.getTypeName().getFullyQualifiedName());

So annotation.getTypeName().getFullyQualifiedName() is not returning the fully qualified name. Is there any chance the annotation element is not resolved ? Definitely a bug. Would need to investigate to figure out what's going wrong with the annotation.

[jeffmaury]

Interesting, so immediately above that is line 186, which is AnnotationUtils.isMatchAnnotation(..)

lsp4mp/microprofile.jdt/org.eclipse.lsp4mp.jdt.core/src/main/java/org/eclipse/lsp4mp/jdt/core/utils/AnnotationUtils.java

Line 186 in 8ccfef8

return annotationName.endsWith(annotation.getTypeName().getFullyQualifiedName());

So annotation.getTypeName().getFullyQualifiedName() is not returning the fully qualified name. Is there any chance the annotation element is not resolved ? Definitely a bug. Would need to investigate to figure out what's going wrong with the annotation.

Yes because getTypeName() returns a SimpleName probably because the annotation is referenced through @ConfigProperties and not the FQCN

[rgrunber]

To me it looks like we don't really support validation/completion for the deprecated ConfigProperties annotation from quarkus. Not sure if we need to though given that it should be done via the MP property. Either way, I think David's change should improve things.

[datho7561]

I created redhat-developer/quarkus-ls#759 to talk/fix this. Maybe the right solution is not validating the Quarkus @ConfigProperties at all, but either way, we should remove the tests in lsp4mp that reference it.