Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MicroProfileHealthDiagnosticsParticipant incompatible with MicroProfile Health 3.0 and later #314

Closed
jeffmaury opened this issue Nov 15, 2022 · 4 comments · Fixed by #316
Closed

MicroProfileHealthDiagnosticsParticipant incompatible with MicroProfile Health 3.0 and later #314

jeffmaury opened this issue Nov 15, 2022 · 4 comments · Fixed by #316
Labels
bug Something isn't working
Milestone
0.6.0

Comments

@jeffmaury
Copy link
Contributor

lsp4mp/microprofile.jdt/org.eclipse.lsp4mp.jdt.core/src/main/java/org/eclipse/lsp4mp/jdt/internal/health/java/MicroProfileHealthDiagnosticsParticipant.java

Line 75 in 2d7d129

return JDTTypeUtils.findType(javaProject, HEALTH_ANNOTATION) != null;

@rgrunber rgrunber added the bug Something isn't working label Nov 15, 2022
@rgrunber
Copy link
Contributor

Yup, https://download.eclipse.org/microprofile/microprofile-health-3.0/microprofile-health-spec-3.0.html#_different_kinds_of_health_checks , should be easy to either check any of the 3 (Health, Readiness, Liveness), or the HealthCheck type.

@jeffmaury
Copy link
Contributor Author

Health should not be used because it has been removed, that's the point

@rgrunber
Copy link
Contributor

If we don't need to maintain any compatibility for 2.0, then yes, we can just remove that.

@jeffmaury
Copy link
Contributor Author

jeffmaury commented Nov 15, 2022 •
edited

We need to support 2.0 as well as 3.0 but this can be achieved by using Liveness, Readiness or HealthCheck rather than a deprecated annotation type to detect MicroProfile Health for the project.

@jeffmaury jeffmaury mentioned this issue Nov 15, 2022
Closed
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Nov 15, 2022
@datho7561
Check for HealthCheck instead of Health before validation
5968255 
Check to make sure that `HealthCheck` is on the classpath
before before performing the microprofile-health specific validations.
Health was removed in microprofile-health 3.0.

Fixes eclipse#314

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Nov 15, 2022
Merged
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Nov 16, 2022
@datho7561
Check for HealthCheck instead of Health before validation
a36b50d 
- Check to make sure that `HealthCheck` is on the classpath
  before before performing the microprofile-health specific validations.
  Health was removed in microprofile-health 3.0.
- Modify the diagnostic messages and code lens to account for the fact
  that @health might not be present

Fixes eclipse#314

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Nov 16, 2022
@datho7561
Check for HealthCheck instead of Health before validation
3d287c5 
- Check to make sure that `HealthCheck` is on the classpath
  before before performing the microprofile-health specific validations.
  Health was removed in microprofile-health 3.0.
- Modify the diagnostic messages and code lens to account for the fact
  that @health might not be present

Fixes eclipse#314

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Nov 16, 2022
@datho7561
Check for HealthCheck instead of Health before validation
175828e 
- Check to make sure that `HealthCheck` is on the classpath
  before before performing the microprofile-health specific validations.
  Health was removed in microprofile-health 3.0.
- Modify the diagnostic messages and code lens to account for the fact
  that @health might not be present

Fixes eclipse#314

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Nov 16, 2022
@datho7561
Check for HealthCheck instead of Health before validation
f95c995 
- Check to make sure that `HealthCheck` is on the classpath
  before before performing the microprofile-health specific validations.
  Health was removed in microprofile-health 3.0.
- Modify the diagnostic messages and code lens to account for the fact
  that @health might not be present

Fixes eclipse#314

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 added this to the 0.6.0 milestone Nov 16, 2022
datho7561 added a commit that referenced this issue Nov 16, 2022
@datho7561
Check for HealthCheck instead of Health before validation
bfcef64 
- Check to make sure that `HealthCheck` is on the classpath
  before before performing the microprofile-health specific validations.
  Health was removed in microprofile-health 3.0.
- Modify the diagnostic messages and code lens to account for the fact
  that @health might not be present

Fixes #314

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Check for HealthCheck instead of Health before validation datho7561/lsp4mp
3 participants
@jeffmaury @rgrunber @datho7561