Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate defaultValue of @ConfigProperty #90

Closed
angelozerr opened this issue Oct 1, 2020 · 1 comment · Fixed by #155
Closed

Validate defaultValue of @ConfigProperty #90

angelozerr opened this issue Oct 1, 2020 · 1 comment · Fixed by #155
Assignees
@rgrunber @angelozerr
Labels
enhancement New feature or request java-files Features supported in Java files validation
Milestone
0.4.0

Comments

@angelozerr
Copy link

angelozerr commented Oct 1, 2020 •
edited

Validate defaultValue of @ConfigProperty according the field type.

Given this sample:

@ConfigProperty(name = "greeting.message" defaultValue="XXXXXXXXXXXXXXX")
Integer intValue;

We should have XXXXXXXXXXXXXXX which is highlighted as error because the expected value is an Integer.

This feature must be implemented on JDT LS side with the com.redhat.microprofile.jdt.core.javaFeatureParticipants diagnostics extension point.

As we have validation for value type in MicroProfile LS for application.properties, it should be good to move all possible validator features in the org.eclipse.lsp4mp.microprofile.commons package.
@angelozerr angelozerr added enhancement New feature or request java-files Features supported in Java files validation labels Oct 1, 2020
@angelozerr angelozerr mentioned this issue Oct 1, 2020
Closed
@angelozerr angelozerr self-assigned this Nov 20, 2020
@angelozerr angelozerr added this to the 0.2.0 milestone Nov 20, 2020
@angelozerr angelozerr modified the milestones: 0.2.0, 0.3.0 Mar 31, 2021
@rgrunber
Copy link
Contributor

Relevant document on what is supported for defaultValue : https://github.com/eclipse/microprofile-config/blob/master/spec/src/main/asciidoc/converters.asciidoc .

rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Jul 22, 2021
@rgrunber
[ WIP ] Validate defaultValue of @ConfigProperty
3daefd6 
- Use documentation from org.eclipse.microprofile.config.spi.Converter
- Fixes eclipse#90

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber mentioned this issue Jul 22, 2021
Merged
rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Jul 23, 2021
@rgrunber
Validate defaultValue of @ConfigProperty
a2c90ab 
- Use documentation from org.eclipse.microprofile.config.spi.Converter
- Fixes eclipse#90

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Jul 23, 2021
@rgrunber
Validate defaultValue of @ConfigProperty
db0eb08 
- Use documentation from org.eclipse.microprofile.config.spi.Converter
- Fixes eclipse#90

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Jul 26, 2021
@rgrunber
Validate defaultValue of @ConfigProperty
897d2ea 
- Use documentation from org.eclipse.microprofile.config.spi.Converter
- Fixes eclipse#90
- Add testcase

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Jul 26, 2021
@rgrunber
Validate defaultValue of @ConfigProperty
da10519 
- Use documentation from org.eclipse.microprofile.config.spi.Converter
- Fixes eclipse#90
- Add testcase

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
angelozerr pushed a commit that referenced this issue Jul 28, 2021
@rgrunber @angelozerr
Validate defaultValue of @ConfigProperty
c5916d8 
- Use documentation from org.eclipse.microprofile.config.spi.Converter
- Fixes #90
- Add testcase

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@angelozerr angelozerr modified the milestones: 0.3.0, 0.4.0 Jul 28, 2021
@rgrunber rgrunber mentioned this issue Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgrunber rgrunber

@angelozerr angelozerr

Labels
enhancement New feature or request java-files Features supported in Java files validation
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Validate defaultValue of @ConfigProperty rgrunber/lsp4mp
2 participants
@rgrunber @angelozerr