osgi-bundle for oslc4j-client. #7
Conversation
|
Not Verified!! Need a use case to verify this. However, building fine and a plugin is created. |
Created an OSGI Bundle for Lyo Java Client. Change-Id: I8719f933eb0ce04446fb2710c516af27f9b39271 Signed-off-by: Yash Khatri <yash.khatri@scania.com>
yashkhatri
force-pushed
the
osgi-bundle_for_java_client
branch
from
7775991
to
5a85765
Compare
oslc4j-client-bundle/pom.xml
Outdated
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>org.eclipse.lyo.clients</groupId> |
There was a problem hiding this comment.
is it the right group? I don't recall clients being multiple
There was a problem hiding this comment.
Yes. This was the group id in client.java project
oslc4j-client-bundle/pom.xml
Outdated
|
|
||
| <properties> | ||
| <bundle.symbolicName>oslc4j-client-bundle</bundle.symbolicName> | ||
| <bundle.namespace>org.oslc4j.client.bundle</bundle.namespace> |
There was a problem hiding this comment.
I think everything we do here should begin with org.eclipse.lyo
There was a problem hiding this comment.
Agree! We need to change in oslc4j-bundle too. I was just trying to keep it in sync with that.
https://github.com/eclipse/lyo.core/blob/82ec00cf193bb2df00d45321a9d173f1126bb9ce/oslc4j-bundle/pom.xml#L19
oslc4j-client-bundle/pom.xml
Outdated
| org.eclipse.lyo.client.oslcresources, | ||
| </_exportcontents> | ||
| <Import-Package> | ||
| javax.servlet;version="2.5.0", |
There was a problem hiding this comment.
I think the POM file for the client was quite big. Are you sure it will work with such a small number of packages imported once someone tries to invoke it?
There was a problem hiding this comment.
I think it will work fine. Similar was the structure for the OSLC4J-Bundle. However, need to see once we try to use it.
|
Just put it to the 2.4.0 milestone, or shall I leave it for later, @jamsden |
Change-Id: Ibe96b417e91ee71eb5a09c3f0c1ac70dd17d8e21 Signed-off-by: Yash Khatri <yash.khatri@scania.com>
Change-Id: I42ddedc3abe8d3b75ad4b1a677c4ef5acd9ab0f0 Signed-off-by: Yash Khatri <yash.khatri@scania.com>
|
switching milestone to 4.0.0 |
|
Resolved in LyoD |
Created an OSGI Bundle for Lyo Java Client.
Closes #6