This repository has been archived by the owner on Oct 12, 2021. It is now read-only.
New UniversalResourceSingleProvider to support more RDF formats #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2nd try, #9 has too many merge conflicts Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
|
I just applied the changes from #9 but a collection-based test now fails: |
jadelkhoury
suggested changes
Apr 23, 2019
| * | ||
| * @since 4.0.0 | ||
| */ | ||
| public class AbstractRdfProvider { |
There was a problem hiding this comment.
should be an abstract class.
| OslcMediaType.N_TRIPLES_MIME, OslcMediaType.RDF_JSON_MIME, OslcMediaType.RDF_THRIFT_MIME}) | ||
| @Consumes({OslcMediaType.APPLICATION_JSON_LD, OslcMediaType.TEXT_TURTLE, | ||
| OslcMediaType.N_TRIPLES_MIME, OslcMediaType.RDF_JSON_MIME, OslcMediaType.RDF_THRIFT_MIME}) | ||
| public class UniversalResourceSingleProvider extends AbstractRdfProvider |
There was a problem hiding this comment.
handle rdf/xml as well.
| OslcMediaType.N_TRIPLES_MIME, OslcMediaType.RDF_JSON_MIME, OslcMediaType.RDF_THRIFT_MIME}) | ||
| @Consumes({OslcMediaType.APPLICATION_JSON_LD, OslcMediaType.TEXT_TURTLE, | ||
| OslcMediaType.N_TRIPLES_MIME, OslcMediaType.RDF_JSON_MIME, OslcMediaType.RDF_THRIFT_MIME}) | ||
| public class UniversalResourceSingleProvider extends AbstractRdfProvider |
There was a problem hiding this comment.
name suggestion: OslcResourceProvider
| @Consumes({OslcMediaType.APPLICATION_JSON_LD, OslcMediaType.TEXT_TURTLE, | ||
| OslcMediaType.N_TRIPLES_MIME, OslcMediaType.RDF_JSON_MIME, OslcMediaType.RDF_THRIFT_MIME}) | ||
| public class UniversalResourceSingleProvider extends AbstractRdfProvider | ||
| implements MessageBodyReader<IResource>, MessageBodyWriter<IResource> { |
There was a problem hiding this comment.
Can one also add?
implements MessageBodyReader<Collection<? extends IResource>>, MessageBodyWriter<Collection<? extends IResource>>
There was a problem hiding this comment.
No, unfortunately this does not work due to type erasure in Java. See https://softwareengineering.stackexchange.com/questions/219427/implementing-multiple-generic-interfaces-in-java for the background.
There was a problem hiding this comment.
Ok. We simply need to provide other Providers for collection.
Don’t even remember why we said we can do it all in 1 class.
# Conflicts: # oslc4j-jena-provider/src/main/java/org/eclipse/lyo/oslc4j/provider/jena/AbstractOslcRdfXmlProvider.java # oslc4j-jena-provider/src/test/java/org/eclipse/lyo/oslc4j/provider/jena/test/JsonLdTest.java
|
@jadelkhoury you were right, this does not include a Jena Model writer. |
I have one somewhere I can contribute. I'm sure you will want to make changes to that :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd try, #9 has too many merge conflicts
TODO
AbstractRdfProvider