Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get catalogUrl for Configuration Management - Fixes #205 #206

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

isccarrasco
Copy link
Contributor

@isccarrasco isccarrasco commented Oct 7, 2021

Signed-off-by: Mario Jiménez Carrasco mario.carrasco@gmail.com

Description

Adding the section to look for the catalogUrl endpoint of the
Configuration Management service from the Rootservices.

Checklist

  • This PR adds an entry to the CHANGELOG. See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
  • This PR was tested on at least one Lyo OSLC server or adds unit/integration tests.
  • This PR does NOT break the API

Issues

Closes #205

(use exactly this syntax to link to issues, one issue per statement only!)

Adding the section to look for the catalogUrl endpoint of the
Configuration Management service from the Rootservices.

Signed-off-by: Mario Jiménez Carrasco <mario.carrasco@gmail.com>
@jadelkhoury
Copy link
Contributor

@isccarrasco You checked "This PR adds an entry to the CHANGELOG", but can't see a submitted change in the log.

otherwise, the change looks reasonable to me.

@jadelkhoury
Copy link
Contributor

@berezovskyi the Helper under oslc-java-client does not contain this change, but I assume this is fine, since we don't need to keep that library updated.

Copy link
Contributor

@jadelkhoury jadelkhoury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good enough to me.

@isccarrasco
Copy link
Contributor Author

@isccarrasco You checked "This PR adds an entry to the CHANGELOG", but can't see a submitted change in the log.

otherwise, the change looks reasonable to me.

Thanks @jadelkhoury, it was a mistake, I updated the checklist!

@berezovskyi berezovskyi merged commit e1b33ff into eclipse:master Oct 13, 2021
@berezovskyi
Copy link
Member

Changelog updated in 4964793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config PR to Client seems to be lost
3 participants