Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for JDK11 build #222

Merged
merged 15 commits into from Dec 14, 2021
Merged

Prepare for JDK11 build #222

merged 15 commits into from Dec 14, 2021

Conversation

berezovskyi
Copy link
Member

@berezovskyi berezovskyi commented Dec 11, 2021 •
edited

Description

No breaking changes yet, just catching up with tech debt to be able to build under JDK11.

Checklist

  • This PR adds an entry to the CHANGELOG. See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
  • This PR was tested on at least one Lyo OSLC server or adds unit/integration tests.
  • This PR does NOT break the API

Issues

Closes #73; Closes #107; Closes #208

(use exactly this syntax to link to issues, one issue per statement only!)

@berezovskyi
Remove Powermock
581c672 
- Use latest Mockito 3.x version
- Upgrade maven plugin versions
- Manage maven-resources-plugin

Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Bump mockito-core to 4.1.0
933b328 
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Temp commit; debuggin oslc-java-client
ad37b18 
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Fix wink client build and clean up xml-apis dependencies
2a08277 
Also depMgmt duplicates cleanup

Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
ban com.sun.xml.bind:jaxb-impl
50e754d 
except for oslc4j-{registry,wink} that will be removed in 5.0 anyway

Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi berezovskyi changed the title B remove powermock Prepare for JDK11 build Dec 11, 2021
@berezovskyi
Enable JDK 11 build in the test matrix
ee69851 
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi berezovskyi marked this pull request as ready for review December 11, 2021 23:09
@berezovskyi
Update maven.yml
2d94dc9
@berezovskyi
Use newest WAR plugin
3be1619 
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Drop JDK 18ea for now and try to get JDK 17 building
5bece24 
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Fix the matrix
57d0148 
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Disable JDK 17 builds for now and test 12-16 to see where it fails
94fc57e 
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Try bumping to Jena 3.17 to check if it helps build under JDK 16/17
859b379 
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Try bumping to Jena 3.17 / don't enforce commons-io
e6b2dcd 
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Roll back to 3.16
ffc02a9 
Most likely the https://openjdk.java.net/jeps/8252885 caused this problem

Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Copy link
Member Author

Under JDK 11, the build works, and so does under JDK 12-15 incl. Fails under JDK 16 and 17. Two issues, one with a lock and another with the private API access:

2021-12-12T00:19:09.2212399Z 00:19:09.121 [io-compute-0] DEBUG es.weso.shacl.validator.Validator - Node http://www.sampledomain.org/sam#AResource - PropertyShape :04dd4407-9fea-4183-95a1-9869c625ecac
2021-12-12T00:19:09.2341819Z 00:19:09.121 [io-compute-0] DEBUG es.weso.shacl.validator.Validator - component2PropertyChecker. propertyShape: PropertyShape(:04dd4407-9fea-4183-95a1-9869c625ecac,PredicatePath(http://www.sampledomain.org/sam#aStringProperty),List(Pattern(^B,None), MaxLength(10), MinLength(7), MaxCount(1), MinCount(1)),List(),List(),false,List(),false,,None,,,None,None,None,List()), path: PredicatePath(http://www.sampledomain.org/sam#aStringProperty), component: Pattern(^B,None)
2021-12-12T00:19:09.2345863Z 00:19:09.121 [io-compute-0] DEBUG org.apache.jena.shared.LockMRSW - Lock : io-compute-0
2021-12-12T00:19:09.2347453Z 00:19:09.121 [io-compute-0] DEBUG org.apache.jena.shared.LockMRSW - Lock : io-compute-0
2021-12-12T00:19:09.2349180Z 00:19:09.122 [io-compute-0] DEBUG es.weso.shacl.validator.Validator - component2Checker(Pattern(^B,None)
2021-12-12T00:19:09.3113732Z java.lang.IllegalAccessError: class es.weso.utils.RegEx (in unnamed module @0x46d21ee0) cannot access class com.sun.org.apache.xerces.internal.impl.xpath.regex.RegularExpression (in module java.xml) because module java.xml does not export com.sun.org.apache.xerces.internal.impl.xpath.regex to unnamed module @0x46d21ee0
2021-12-12T00:19:09.3117859Z @Prefix rdf: http://www.w3.org/1999/02/22-rdf-syntax-ns# .
2021-12-12T00:19:09.3118987Z at es.weso.utils.RegEx.matches(RegexUtils.scala:17)
2021-12-12T00:19:09.3120319Z at es.weso.shacl.validator.Validator.regexMatch(Validator.scala:447)
2021-12-12T00:19:09.3122108Z at es.weso.shacl.validator.Validator.$anonfun$pattern$2(Validator.scala:441)
2021-12-12T00:19:09.3123525Z at es.weso.shacl.validator.Validator.$anonfun$component2Checker$2(Validator.scala:264)
2021-12-12T00:19:09.3125145Z at es.weso.shacl.validator.Validator.$anonfun$component2PropertyChecker$6(Validator.scala:327)
2021-12-12T00:19:09.3126602Z at scala.collection.immutable.List.map(List.scala:293)
2021-12-12T00:19:09.3127887Z at es.weso.checking.CheckerCats.checkList(CheckerCats.scala:268)
2021-12-12T00:19:09.3129753Z at es.weso.shacl.validator.Validator.checkValues(Validator.scala:282)
2021-12-12T00:19:09.3131460Z at es.weso.shacl.validator.Validator.$anonfun$component2PropertyChecker$3(Validator.scala:327)
2021-12-12T00:19:09.3132762Z at cats.data.EitherT.$anonfun$bimap$1(EitherT.scala:382)
2021-12-12T00:19:09.3255137Z at cats.data.WriterT.$anonfun$map$1(WriterT.scala:117)
2021-12-12T00:19:09.3256269Z at cats.effect.IOFiber.mapK(IOFiber.scala:1187)
2021-12-12T00:19:09.3257330Z at cats.effect.IOFiber.succeeded(IOFiber.scala:1003)
2021-12-12T00:19:09.3258372Z at cats.effect.IOFiber.mapK(IOFiber.scala:1196)
2021-12-12T00:19:09.3259424Z at cats.effect.IOFiber.succeeded(IOFiber.scala:1003)
2021-12-12T00:19:09.3260472Z at cats.effect.IOFiber.mapK(IOFiber.scala:1196)
2021-12-12T00:19:09.3261524Z at cats.effect.IOFiber.succeeded(IOFiber.scala:1003)
2021-12-12T00:19:09.3262598Z at cats.effect.IOFiber.runLoop(IOFiber.scala:250)
2021-12-12T00:19:09.3263693Z at cats.effect.IOFiber.autoCedeR(IOFiber.scala:1174)
2021-12-12T00:19:09.3264756Z at cats.effect.IOFiber.run(IOFiber.scala:133)
2021-12-12T00:19:09.3265941Z at cats.effect.unsafe.WorkerThread.run(WorkerThread.scala:383)

We will have to wait to test with new versions of Jena and SHACLEX.

@berezovskyi
Cache per JDK
82ccd18 
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Copy link
Member Author

Reviewed with Jad

@berezovskyi berezovskyi merged commit 3c63bcd into master Dec 14, 2021
@berezovskyi berezovskyi deleted the b-remove-powermock branch December 14, 2021 14:05
@berezovskyi berezovskyi added this to the 5.0 milestone Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadelkhoury jadelkhoury Awaiting requested review from jadelkhoury

@jamsden jamsden Awaiting requested review from jamsden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@berezovskyi