-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic tests for the RDF and JSON Providers over QC #288
Conversation
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Added an initial test matrix. The tests are failing due to the JSON Provider always returning query results for any array/collection response: Lines 120 to 124 in 88a4c42
Note the |
While finishing #284, I didn't see a place to refactor out common code, thus I duplicated the code for Jena provider tests. We can refactor both tests independent of #284. Now, to the results: it's a bit better than the OSLC JSON provider, but still rough edges (unexpected failures) exist. At least, now they are captured in tests: All responses get valid RDF. With the direct use of JMH, all tests pass. When we try to get JAX-RS to unmarshal the response, we see that all tests pass for the expected Query responses, whereas all but one tests fail for the expected raw collection of resources as a response. Further investigation led me to The PR has been updated to reject arrays and collections from being processed by NB! We should add the |
@jad-elkhoury, I think the PR is ready for review. In process of writing an extensive test matrix, two important discoveries were made:
Minor discovery is that xUpdatedProvidersRegistry and xSimpleProvidersRegistry are next to useless as they silently wipe important data, such as extended properties and URIs. I could not get the tests pass with them. I would suggest to ask around on the mailing list for the use and deprecate those provider registries. |
Description
See #287
Checklist
Issues
Closes #287