Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] build: switch to Jena SNAPSHOT #389

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

berezovskyi
Copy link
Member

@berezovskyi berezovskyi commented Aug 14, 2023

Description

Switch to the latest Jena SNAPSHOT (4.10.0-SNAPSHOT) to anticipate Jena 5 breaking changes. So far we only had to replace usage of the shaded Guava classes (my fault for using them in the first place) and use ReifierStd instead of Statement.listReifiedStatements().

This PR also deals with JDK 17 warnings where possible.

Checklist

  • This PR adds an entry to the CHANGELOG. See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
  • This PR was tested on at least one Lyo OSLC server (e.g. manual workflow on Lyo Sample and OSLC RefImpl) or adds unit/integration tests.
  • This PR does NOT break the API

Issues

Closes #0; Closes #00

(use exactly this syntax to link to issues, one issue per statement only!)

@berezovskyi berezovskyi changed the title build: switch to Jena SNAPSHOT [WIP] build: switch to Jena SNAPSHOT Aug 14, 2023
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Copy link
Member Author

Just migrated from Jena 4.10 SNAPSHOT to 4.11 SNAPSHOT, build succeeds on 17 and 21.

Jena now publishes 5.0 SNAPSHOT too, we could test how we fare.

Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Copy link
Member Author

Bad news, org.apache.jena.rdf.model.ReifiedStatement and org.apache.jena.rdf.model.SimpleSelector are not found in Jena 5. @Jad-el-khoury you will have to look into this, I don't have time to go through the Jena commits and mailing list to figure out further migration steps. Happy to see that Jena made another 4.x release in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant