Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCK must not depend on properties not defined in System or Env #563

Closed
radcortez opened this issue May 15, 2020 · 1 comment
Closed

TCK must not depend on properties not defined in System or Env #563

radcortez opened this issue May 15, 2020 · 1 comment
Labels
bug 🪲 An error in the implementation code or documentation
Milestone
MP Config 2.0

Comments

@radcortez
Copy link
Contributor

Describe the bug

Our ConfigProviderTest TCK test iterates on all system properties and environment variables to check the System and Env Config Sources. We don't have control on which properties and values are available, since they are system dependent. This can cause unexpected TCK failures, for instance if a value ${} is present and config expansion is supported.

The TCK should only check and assert defined properties by the TCK itself.
@radcortez radcortez added the bug 🪲 An error in the implementation code or documentation label May 15, 2020
@radcortez
Copy link
Contributor Author

Fix in #560.

@Emily-Jiang Emily-Jiang added this to the MP Config 2.0 milestone May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🪲 An error in the implementation code or documentation
Projects
None yet
Milestone
MP Config 2.0
Development

No branches or pull requests
2 participants
@radcortez @Emily-Jiang