Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

582 - add release notes #583

Merged
merged 2 commits into from Jul 27, 2020
Merged

Conversation

Emily-Jiang
Copy link
Member

Signed-off-by: Emily Jiang emijiang6@googlemail.com

Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
@Emily-Jiang
Copy link
Member Author

@jbee @radcortez please review. If possible, I would like to merge tomorrow so that I can kick off a release.

Copy link
Contributor

@jbee jbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items give a explanatory short summary - nice job.
Two exceptions where I suggested a small change.

(I did not check if something is missing)

- The `ConfigSource` SPI has been extended with a default method that returns the property names for a given `ConfigSource` (link:https://github.com/eclipse/microprofile-config/issues/178[#178])
- Convenience methods have been added to Config allowing for the retrieval of multi-valued properties as lists instead of arrays (link:https://github.com/eclipse/microprofile-config/issues/496[#496])
- Support Configuration Profile so that the corresponding properties associated with the active profile will be used (link:https://github.com/eclipse/microprofile-config/issues/418[#418])
- Enable isolation of config properties into a separate POJO by introducing `@ConfigProperties` (link:https://github.com/eclipse/microprofile-config/issues/240[240])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Enable isolation of config properties into a separate POJO by introducing `@ConfigProperties` (link:https://github.com/eclipse/microprofile-config/issues/240[240])
- Enable bulk-extraction of config properties into a separate POJO by introducing `@ConfigProperties` (link:https://github.com/eclipse/microprofile-config/issues/240[240])

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


=== Functional Changes
- Provide built-in Converters: OptinalInt, OptionalLong and OptionalDouble (link:https://github.com/eclipse/microprofile-config/issues/513[513])
- Clarify behaviour of Converters for primitive wrappers (link:https://github.com/eclipse/microprofile-config/issues/520[520])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording requires the reader to chase and look for the effect of the clarification. I think it should state the outcome shortly, like

Suggested change
- Clarify behaviour of Converters for primitive wrappers (link:https://github.com/eclipse/microprofile-config/issues/520[520])
- Clarifies that Converters for primitive wrappers apply to primitive types as well (link:https://github.com/eclipse/microprofile-config/issues/520[520])

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


=== API/SPI Changes

- The `ConfigSource` SPI has been extended with a default method that returns the property names for a given `ConfigSource` (link:https://github.com/eclipse/microprofile-config/issues/178[#178])
- Convenience methods have been added to Config allowing for the retrieval of multi-valued properties as lists instead of arrays (link:https://github.com/eclipse/microprofile-config/issues/496[#496])
- Support Configuration Profile so that the corresponding properties associated with the active profile will be used (link:https://github.com/eclipse/microprofile-config/issues/418[#418])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Support Configuration Profile so that the corresponding properties associated with the active profile will be used (link:https://github.com/eclipse/microprofile-config/issues/418[#418])
- Support Configuration Profiles so that the corresponding properties associated with the active profile are used (link:https://github.com/eclipse/microprofile-config/issues/418[#418])

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@radcortez
Copy link
Contributor

We are missing #84. The ML was not set up correctly.

@Emily-Jiang
Copy link
Member Author

We are missing #84. The ML was not set up correctly.

Well spotted. I was off today and realised earlier I missed this one. Thanks for filing for the release candidate.

Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
@Emily-Jiang Emily-Jiang merged commit 6b7c8ac into eclipse:master Jul 27, 2020
@Emily-Jiang Emily-Jiang mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants