Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TCK tests for MicroProfile Concurrency #60

Closed
51 tasks done
njr-11 opened this issue Dec 12, 2018 · 2 comments
Closed
51 tasks done

Add TCK tests for MicroProfile Concurrency #60

njr-11 opened this issue Dec 12, 2018 · 2 comments

Comments

@njr-11
Copy link
Contributor

njr-11 commented Dec 12, 2018

Unless someone else knows of a better way to track this, I'm intending for this issue to be a place to document and collaborate on a list of test scenarios for the MicroProfile Concurrency TCK.

The following will be a checklist of scenarios. There are only a couple to start with, which seemed like some basic things we will need to start making progress. Sign up for a scenario to the TCK by mentioning the git pull number under which you are adding it. When the pull is merged, check the box next to it to indicate it is done,

As discussed on the prior MicroProfile Concurrency call (2019-2-21), the above represents the full set of desired TCK scenarios sufficient for the initial release candidate.

njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 12, 2018
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
@nmittles
Copy link
Contributor

Suggestions for basic TCK scenarios of ManagedExecutor, ThreadContext and their builders:

  • verify ManagedExecutor.Builder().maxAsync(X).build() boundaries; 1, -1, and maxInt is successful for X; 0 and -2 throw an IllegalArgumentException for X
  • verify ManagedExecutor.Builder().maxQueued(X).build() boundaries; 1, -1, and maxInt is successful for X; 0 and -2 throw an IllegalArgumentException for X
  • verify ManagedExecutor.Builder() API methods: build(), propagated(), cleared(), maxAsync(), maxQueued()
  • verify ManagedExecutor API methods: builder(), completedFuture(), completedStage(), failedFuture(), failedStage(), newIncompleteFuture(), runAsync(), supplyAsync()
  • verify ThreadContext.Builder() API methods: build(), cleared(), propagated(), unchanged()
  • verify ThreadContext API methods: currentContextExecutor(), contextualCallable(), contextualConsumer(), contextualFunction(), contextualRunnable(), contextualSupplier(), and withContextCapture()
  • verify ThreadContext constants are defined: TRANSACTION, SECURITY, CDI, ALL_REMAINING, and APPLICATION

@njr-11
Copy link
Contributor Author

njr-11 commented Dec 13, 2018

@nmittles Thanks for coming up with those scenarios. I believe I've added all of the ones you proposed to the list now, splitting up a few of them up into separate scenarios where too much was included in a single scenario

njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 13, 2018
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 16, 2018
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 16, 2018
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 18, 2018
…or newIncompleteFuture, runAsync, and supplyAsync

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 18, 2018
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 18, 2018
…iledStage, and failedFuture method of ManagedExecutor

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 19, 2018
…he context within stage 3 of the test for context propagation for dependent stages of completedFuture
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 19, 2018
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 19, 2018
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 21, 2018
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 21, 2018
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 30, 2018
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Dec 31, 2018
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 2, 2019
… will provide 2 threads to concurrently run async actions

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 2, 2019
… will provide 2 threads to concurrently run async actions

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 3, 2019
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 8, 2019
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 9, 2019
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 11, 2019
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 14, 2019
…ig being used to override the configuration of container produced instances

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 14, 2019
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 15, 2019
…injected into method parameter

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 15, 2019
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 16, 2019
…e Config

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 17, 2019
…ith parameter position above 1

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 17, 2019
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 22, 2019
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 28, 2019
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 29, 2019
…utor and ThreadContext based on NamedInstance qualifier

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 30, 2019
…utor and ThreadContext based on NamedInstance qualifier

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 30, 2019
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Jan 31, 2019
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Feb 1, 2019
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Feb 3, 2019
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Feb 3, 2019
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Feb 3, 2019
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Feb 5, 2019
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Feb 5, 2019
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Feb 6, 2019
…rameter does not override the context propagation

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
FroMage added a commit to smallrye/smallrye-context-propagation that referenced this issue Feb 8, 2019
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Feb 11, 2019
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Feb 11, 2019
njr-11 added a commit to njr-11/microprofile-context-propagation that referenced this issue Feb 14, 2019
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
@njr-11 njr-11 closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants