Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more configuration based TCK tests #182

Closed
johnament opened this issue Oct 28, 2017 · 4 comments
Closed

Add more configuration based TCK tests #182

johnament opened this issue Oct 28, 2017 · 4 comments
Assignees
@antoinesd
Labels
tests
Milestone
1.1

Comments

@johnament
Copy link
Contributor

The following behaviors are not tested:

  • Having a property set for both the method and the class
  • Having a property set in a global fashion that overrides the other class/method annotations
  • Property configuration for global
  • Bulkhead configuration
  • CircuitBreaker configuration
  • Timeout configuration
  • Exception class conversion (should this be moved to the config spec?)
  • TimeUnit conversion (should this be moved to the config spec?)
@Emily-Jiang
Copy link
Member

Thanks for reporting this @johnament ! Feel free to submit PR if you get to it first.

@OndroMih OndroMih added the tests label Oct 31, 2017
@Emily-Jiang Emily-Jiang added this to the 1.1 milestone Nov 30, 2017
@Emily-Jiang
Copy link
Member

@antoinesd can you help with this?

@antoinesd
Copy link
Contributor

yes @Emily-Jiang

@antoinesd antoinesd self-assigned this Dec 5, 2017
antoinesd added a commit to antoinesd/microprofile-fault-tolerance that referenced this issue Dec 15, 2017
@antoinesd
#microprofile-fault-tolerance-182 Add more configuration based TCK tests
b909511 
Solve eclipse#182

Signed-off-by: Antoine Sabot-Durand <antoine@sabot-durand.net>
@antoinesd antoinesd mentioned this issue Dec 15, 2017
Merged
@antoinesd
Copy link
Contributor

Added PR. Test related to converters should be added to config IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoinesd antoinesd

Labels
tests
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
4 participants
@johnament @antoinesd @OndroMih @Emily-Jiang