Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCK is missing tests for standalone Asynchronous #194

Closed
mkouba opened this issue Nov 14, 2017 · 10 comments

Comments

Projects
None yet
5 participants
@mkouba
Copy link
Contributor

commented Nov 14, 2017

See also https://github.com/eclipse/microprofile-fault-tolerance/blob/master/tck/src/main/java/org/eclipse/microprofile/fault/tolerance/tck/AsynchronousInvocation.java

The TCK also misses a test that FaultToleranceDefinitionException is thrown if a method annotated with @Asynchronous does not return Future.

@johnament

This comment has been minimized.

Copy link
Member

commented Nov 14, 2017

Is it supposed to be a constraint? I honestly had no idea.

@antoinesd

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2017

In section 4.1, the spec states:

The method annotated with @Asynchronous must return a Future, otherwise, FaultToleranceDefinitionException occurs

So it looks like a constraint.

@johnament

This comment has been minimized.

Copy link
Member

commented Nov 14, 2017

But I can also apply @Asynchronous to a class. I can also add @Bulkhead to the mix and then what's expected?

@mkouba

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2017

I would guess @Asynchronous declared on a class => all methods must return Future.

@antoinesd

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2017

+1

@Emily-Jiang

This comment has been minimized.

Copy link
Member

commented Nov 14, 2017

yes @mkouba !

@Emily-Jiang

This comment has been minimized.

Copy link
Member

commented Nov 14, 2017

please feel free to do a PR to add tests @mkouba !

@Emily-Jiang

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

@antoinesd @mkouba pls help with adding more tests.

@antoinesd

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2017

Taking it

@antoinesd antoinesd self-assigned this Dec 5, 2017

@Emily-Jiang Emily-Jiang added this to the 1.1 milestone Dec 6, 2017

@antoinesd antoinesd added the tests label Dec 7, 2017

@arjantijms

This comment has been minimized.

Copy link

commented Feb 17, 2018

Just a though, but wouldn't a standalone @asynchronous annotation more belong in a concurrency spec?

antoinesd added a commit to antoinesd/microprofile-fault-tolerance that referenced this issue Feb 17, 2018

eclipse#194 TCK is missing tests for standalone Asynchronous
solves eclipse#194

Signed-off-by: Antoine Sabot-Durand <antoine@sabot-durand.net>

Emily-Jiang added a commit that referenced this issue Mar 6, 2018

Merge pull request #226 from antoinesd/issue-194
#194 TCK is missing tests for standalone Asynchronous

@Emily-Jiang Emily-Jiang closed this Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.