Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCK is missing tests for standalone Asynchronous #194

Closed
mkouba opened this issue Nov 14, 2017 · 10 comments
Closed

TCK is missing tests for standalone Asynchronous #194

mkouba opened this issue Nov 14, 2017 · 10 comments
Assignees
Labels
Milestone

Comments

@mkouba
Copy link
Contributor

mkouba commented Nov 14, 2017

See also https://github.com/eclipse/microprofile-fault-tolerance/blob/master/tck/src/main/java/org/eclipse/microprofile/fault/tolerance/tck/AsynchronousInvocation.java

The TCK also misses a test that FaultToleranceDefinitionException is thrown if a method annotated with @Asynchronous does not return Future.

@johnament
Copy link
Contributor

Is it supposed to be a constraint? I honestly had no idea.

@antoinesd
Copy link
Contributor

In section 4.1, the spec states:

The method annotated with @Asynchronous must return a Future, otherwise, FaultToleranceDefinitionException occurs

So it looks like a constraint.

@johnament
Copy link
Contributor

But I can also apply @Asynchronous to a class. I can also add @Bulkhead to the mix and then what's expected?

@mkouba
Copy link
Contributor Author

mkouba commented Nov 14, 2017

I would guess @Asynchronous declared on a class => all methods must return Future.

@antoinesd
Copy link
Contributor

+1

@Emily-Jiang
Copy link
Member

yes @mkouba !

@Emily-Jiang
Copy link
Member

please feel free to do a PR to add tests @mkouba !

@Emily-Jiang
Copy link
Member

@antoinesd @mkouba pls help with adding more tests.

@antoinesd
Copy link
Contributor

Taking it

@antoinesd antoinesd self-assigned this Dec 5, 2017
@Emily-Jiang Emily-Jiang added this to the 1.1 milestone Dec 6, 2017
@antoinesd antoinesd added the tests label Dec 7, 2017
@arjantijms
Copy link

Just a though, but wouldn't a standalone @asynchronous annotation more belong in a concurrency spec?

antoinesd added a commit to antoinesd/microprofile-fault-tolerance that referenced this issue Feb 17, 2018
solves eclipse#194

Signed-off-by: Antoine Sabot-Durand <antoine@sabot-durand.net>
Emily-Jiang added a commit that referenced this issue Mar 6, 2018
#194 TCK is missing tests for standalone Asynchronous
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants