Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulkhead TCK tests - timing issue in TestData.check() #227

Closed
mkouba opened this issue Mar 5, 2018 · 3 comments · Fixed by #244
Closed

Bulkhead TCK tests - timing issue in TestData.check() #227

mkouba opened this issue Mar 5, 2018 · 3 comments · Fixed by #244
Assignees
@hutchig
Milestone
1.1

Comments

@mkouba
Copy link
Contributor

mkouba commented Mar 5, 2018

The number of workers may be decremented AFTER the count of the latch is decremented. See also https://github.com/eclipse/microprofile-fault-tolerance/blob/master/tck/src/main/java/org/eclipse/microprofile/fault/tolerance/tck/bulkhead/clientserver/Checker.java#L111

As a result, an assert in TestData.check() may fail incorrectly.

We've managed to reproduce the issue in WildFly Swarm with org.eclipse.microprofile.fault.tolerance.tck.bulkhead.BulkheadAsynchRetryTest.testBulkheadQueReplacesDueToClassRetryFailures().
mkouba added a commit to mkouba/wildfly-swarm that referenced this issue Mar 5, 2018
@mkouba
Exclude BulkheadSynchRetryTest.testBulkheadQueReplacesDueToClassRetry…
c779148 
…Failures()

- this test has a timing issue and fails intermittently
- see also
eclipse/microprofile-fault-tolerance#227
@mkouba mkouba mentioned this issue Mar 5, 2018
Merged
mkouba added a commit to mkouba/wildfly-swarm that referenced this issue Mar 5, 2018
@mkouba
SWARM-1868: Exclude BulkheadSynchRetryTest.testBulkheadQueReplacesDue…
df67a32 
…ToClassRetryFailures()

- this test has a timing issue and fails intermittently
- see also
eclipse/microprofile-fault-tolerance#227
kenfinnigan pushed a commit to thorntail/thorntail that referenced this issue Mar 5, 2018
@mkouba @kenfinnigan
SWARM-1868: Exclude BulkheadSynchRetryTest.testBulkheadQueReplacesDue…
fe9c444 
…ToClassRetryFailures() (#821)

- this test has a timing issue and fails intermittently
- see also
eclipse/microprofile-fault-tolerance#227
@Emily-Jiang
Copy link
Member

@hutchig can you take a look at this one?

@hutchig
Copy link
Member

hutchig commented Mar 19, 2018

@Emily-Jiang OK. Will do.

@Emily-Jiang Emily-Jiang added this to the 1.1 milestone Mar 28, 2018
@hutchig hutchig self-assigned this Apr 4, 2018
@hutchig
Copy link
Member

hutchig commented Apr 6, 2018

I have moved the latch decrement to the finally block after the
workers count decrement. Just batch testing now.

@hutchig hutchig mentioned this issue Apr 6, 2018
Merged
@mkouba mkouba mentioned this issue Apr 19, 2018
Merged
@tevans78 tevans78 mentioned this issue Sep 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hutchig hutchig

Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Fix to race condition in TCK bulkhead Checker hutchig/microprofile-fault-tolerance
3 participants
@mkouba @hutchig @Emily-Jiang