Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TCK fixes 2.0.x #527

Merged
merged 3 commits into from
Apr 8, 2020
Merged

Add TCK fixes 2.0.x #527

merged 3 commits into from
Apr 8, 2020

Conversation

Joseph-Cass
Copy link

@Joseph-Cass Joseph-Cass commented Apr 3, 2020 •
edited

Introduces the following PR's:
#520 - Updated AllMetricsBean
#517 - TimeoutUninterruptableTest scaling issue fix
#511 - Make concurrent execution tracker configurable

This branch did not work for Java 11 or 13 for me.

Only Java 8:

josephcass$ java -version
openjdk version "1.8.0_242"
OpenJDK Runtime Environment (build 1.8.0_242-b08)
Eclipse OpenJ9 VM (build openj9-0.18.1, JRE 1.8.0 Mac OS X amd64-64-Bit Compressed References 20200122_439 (JIT enabled, AOT enabled)
OpenJ9   - 51a5857d2
OMR      - 7a1b0239a
JCL      - 8cf8a30581 based on jdk8u242-b08)```

@JCass149
Introduce Updated AllMetricsBean eclipse#520
4dd8cee 
Signed-off-by: Joseph Cass <joseph.cass@ibm.com>
@JCass149
Introduce Fixed TimeoutUninterruptableTest scaling issue with TCKConf…
96c2f11 
…ig baseMultiplier eclipse#517

Signed-off-by: Joseph Cass <joseph.cass@ibm.com>
@JCass149
Introduce Make timeout for concurrent execution tracker configurable e…
38877dc 
…clipse#511

Signed-off-by: Joseph Cass <joseph.cass@ibm.com>
@eclipse-microprofile-bot
Copy link
Contributor

Can one of the admins verify this patch?

@Joseph-Cass Joseph-Cass changed the title Add TCK fixes Add TCK fixes 2.0.x Apr 3, 2020
Emily-Jiang
Emily-Jiang approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Emily-Jiang
Copy link
Member

@genie-microprofile test

@Ladicek
Copy link
Contributor

Ladicek commented Apr 6, 2020

Do we plan to do a release in the 2.0.x stream?

@Azquelt
Copy link
Member

Azquelt commented Apr 6, 2020

@genie-microprofile test this please

@Azquelt
Copy link
Member

Azquelt commented Apr 6, 2020

Do we plan to do a release in the 2.0.x stream?

I'd really like to, we still run the 2.0 TCK in our CI builds and still get a few timing related failures which should be resolved by these changes.

@Ladicek
Copy link
Contributor

Ladicek commented Apr 6, 2020

Ah OK.

@Emily-Jiang Emily-Jiang merged commit 3d81538 into eclipse:2.0.x Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@Azquelt Azquelt Azquelt approved these changes

@Emily-Jiang Emily-Jiang Emily-Jiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Joseph-Cass @eclipse-microprofile-bot @Emily-Jiang @Ladicek @Azquelt @JCass149