Add timeout config to RetryTest and CircuitBreakerTimeoutTest #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
Azquelt
force-pushed
the
retry-delay-timeout-config
branch
from
b3b36fe
to
de616f5
Compare
|
@Azquelt can you open an issue for this so that all PRs for different branches can be associated with it? |
Emily-Jiang
reviewed
May 15, 2020
| @@ -1,6 +1,6 @@ | |||
| /* | |||
| ******************************************************************************* | |||
| * Copyright (c) 2018 Contributors to the Eclipse Foundation | |||
| * Copyright (c) 2018-2020 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
If this is wrong, then it's wrong almost everywhere.
If it needs fixed, we should probably do a mass change over the whole repo.
Emily-Jiang
reviewed
May 15, 2020
| @@ -1,6 +1,6 @@ | |||
| /* | |||
| ******************************************************************************* | |||
| * Copyright (c) 2018 Contributors to the Eclipse Foundation | |||
| * Copyright (c) 2018-2020 Contributors to the Eclipse Foundation | |||
Emily-Jiang
reviewed
May 15, 2020
| @@ -1,6 +1,6 @@ | |||
| /* | |||
| ******************************************************************************* | |||
| * Copyright (c) 2016-2017 Contributors to the Eclipse Foundation | |||
| * Copyright (c) 2016-2020 Contributors to the Eclipse Foundation | |||
Ladicek
approved these changes
May 15, 2020
Yes, will raise those PRs shortly. |
|
@Emily-Jiang If you're happy for me to address the copyright date formatting under #545, then I think this (and the two backport PRs #546 and #547) are ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the latest RC, I saw a failure I hadn't seen before in
RetryTestwhere the timing is fairly tight and the test wasn't usingTCKConfig.After fixing that, I had a look through to see if there were any more tests which should clearly be using
TCKConfigbut aren't and I foundCircuitBreakerTimeoutTestso I've fixed that too.Fixes #544