Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for creation of referenced types #219

Merged
merged 1 commit into from Apr 8, 2020

Conversation

ybroeker
Copy link
Contributor

@ybroeker ybroeker commented Apr 4, 2020

This PR adds tests for creation of types which are used as fields but not directly as return- or parameter-types of queries and mutations.

Signed-off-by: Yannick Bröker <ybroeker@techfak.uni-bielefeld.de>
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ybroeker . @andymc12 can you also have a look ? Thanks

@ybroeker ybroeker changed the title Add tests for creation if referenced types Add tests for creation of referenced types Apr 6, 2020
Copy link
Contributor

@andymc12 andymc12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillip-kruger phillip-kruger merged commit ae0f27d into eclipse:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants