Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue220 Mark spec dependencies as "provided" #255

Merged
merged 2 commits into from May 22, 2020
Merged

Issue220 Mark spec dependencies as "provided" #255

merged 2 commits into from May 22, 2020

Conversation

xstefank
Copy link
Member

resolves #220

@xstefank xstefank requested a review from antoinesd May 22, 2020 13:27
@xstefank
Copy link
Member Author

@pgunapal can you also take a look please?

@xstefank
Add provided scope to API dependencies
309677f 
Signed-off-by: xstefank <xstefank122@gmail.com>
@xstefank
Exclude EJB API from Jakarta CDI dependency
9f19531 
Signed-off-by: xstefank <xstefank122@gmail.com>
pgunapal
pgunapal approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@pgunapal pgunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xstefank xstefank merged commit 5c2f336 into eclipse:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgunapal pgunapal pgunapal approved these changes

@antoinesd antoinesd Awaiting requested review from antoinesd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark spec dependencies as "provided"
2 participants
@xstefank @pgunapal