Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'build' from .gitignore #205

Closed
wants to merge 1 commit into from

Conversation

sberyozkin
Copy link
Contributor

Fixes #192

@sberyozkin sberyozkin added this to the MPJWT-1.2 milestone Aug 26, 2020
@rdebusscher
Copy link
Member

rdebusscher commented Aug 26, 2020

Any reason why the contents of build directories needs to be in the git repo? It was probably there for a reason

@sberyozkin
Copy link
Contributor Author

@rdebusscher Hi, see #192

It is not a big deal that for example a future builder API would have builder package as opposed to build (the latter is more compact) but keeping build ignored just in case is not worth on its own, neither Eclipse nor IntelliJ nor Maven apparently have this folder generated.
I've no strong opinion but I'd like to see someone actually saying, wait. my IDE generates build.
It was added here:
792c581#diff-a084b794bc0759e7a6b77810e01874f2

Let me ask @starksm64 Hi Scott, was there any particular reason build was added in .gitignore ?

My best bet is that it is the Ant legacy and build is a copy and paste side-effect, but I won't rush

@sberyozkin
Copy link
Contributor Author

sberyozkin commented Aug 26, 2020

For the record, smallrye-jwt JWT builder API which the build JWT PR was based around has a build sub-package but we haven't seen anyone reporting any issues around it in the Quarkus/smallrye-jwt land for the last 6+ months.

@rdebusscher
Copy link
Member

Then there was maybe a typo in the .gitignore initially when ant build directory was meant to exclude (should be /build instead of build/)

@sberyozkin sberyozkin removed this from the MPJWT-1.2 milestone Sep 10, 2020
@sberyozkin sberyozkin closed this Feb 27, 2024
@sberyozkin sberyozkin deleted the git_ignore_build branch February 27, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gitignore 'build' exclusion
4 participants