Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarifications around timeout of participant. #234

Closed
wants to merge 1 commit into from
Closed

Clarifications around timeout of participant. #234

wants to merge 1 commit into from

Conversation

rdebusscher
Copy link
Member

No description provided.

@rdebusscher rdebusscher added this to the 1.0 milestone Sep 9, 2019
@rdebusscher
Copy link
Member Author

@xstefank FYI

xstefank
xstefank requested changes Sep 10, 2019
View reviewed changes
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, only one small comment

spec/src/main/asciidoc/microprofile-lra-spec.adoc
@@ -1010,13 +1010,16 @@ example, to indicate that an LRA should automatically cancel after 100 milliseco
----

Furthermore, the ability to compensate or complete may be transient capabilities of a
service so participants can also be timed out. When the time limit is reached
service so participants can also be timed out. When the time limit is reached of the participant,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
service so participants can also be timed out. When the time limit is reached of the participant,
service so participants can also be timed out. When the time limit of the participant is reached,

mmusgrov
mmusgrov reviewed Sep 12, 2019
View reviewed changes
Copy link
Contributor

@mmusgrov mmusgrov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this PR relate to issue #233

@rdebusscher
Copy link
Member Author

@mmusgrov It doesn't relate directly to that issue.

When reviewing the spec/javadoc around timeout, I found some small issue (the to the @Compensate **and** @Complete) and added a few clarifications.

I'll close this one and integrate it in PR for #233 now that we have agreed on that one.

@rdebusscher
Copy link
Member Author

No longer valid due to changed scope of #233

@rdebusscher rdebusscher deleted the timeout branch January 31, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmusgrov mmusgrov mmusgrov left review comments

@xstefank xstefank xstefank requested changes

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rdebusscher @mmusgrov @xstefank