Remove timeLimit and timeUnit for @Compensate and @Complete #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xstefank FYI |
xstefank
reviewed
Sep 16, 2019
mmusgrov
requested changes
Sep 19, 2019
api/src/main/java/org/eclipse/microprofile/lra/annotation/Compensate.java
Show resolved
Hide resolved
xstefank
approved these changes
Sep 20, 2019
mmusgrov
reviewed
Sep 24, 2019
api/src/main/java/org/eclipse/microprofile/lra/annotation/Compensate.java
Outdated
Show resolved
Hide resolved
mmusgrov
reviewed
Sep 24, 2019
| indicate that its' ability to compensate is limited to 100 milliseconds could be: | ||
| Furthermore, the ability to compensate or complete may be transient capabilities of a service so participants can also be timed out. | ||
| When the timeout is reached, the LRA moves to the state `Cancelling` and all registered participants receive a `Compensate` | ||
| call. The same actions are performed then the case where the LRA is canceled. |
There was a problem hiding this comment.
The grammar is odd, better is:
The same actions are performed as in the case when an LRA is cancelled.
|
How does this issue relate to issue #233 |
mmusgrov
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233