Address comments: fix missing quantile tag, typo

eclipse · Aug 23, 2022 · 1ea33a7 · 1ea33a7
1 parent 5235693
commit 1ea33a7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/spec/src/main/asciidoc/base-metrics.adoc b/spec/src/main/asciidoc/base-metrics.adoc
@@ -310,12 +310,12 @@ The OpenMetrics formatted rest metrics would be:
 # TYPE REST_request_seconds_max gauge
 REST_request_seconds_max{class="org.eclipse.microprofile.metrics.demo.RestDemo",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base"} 1.0
 # TYPE REST_request_seconds summary
-REST_request_seconds{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base"} 0.99999744
-REST_request_seconds{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base"} 0.99999744
-REST_request_seconds{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base"} 0.99999744
-REST_request_seconds{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base"} 0.99999744
-REST_request_seconds{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base"} 0.99999744
-REST_request_seconds{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base"} 0.99999744
+REST_request_seconds{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base",quantile="0.5"} 0.99999744
+REST_request_seconds{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base",quantile="0.75"} 0.99999744
+REST_request_seconds{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base",quantile="0.95"} 0.99999744
+REST_request_seconds{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base",quantile="0.98"} 0.99999744
+REST_request_seconds{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base",quantile="0.99"} 0.99999744
+REST_request_seconds{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base",quantile="0.999"} 0.99999744
 REST_request_seconds_count{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base"} 1.0
 REST_request_seconds_sum{class="com.ibm.metrics.demo.MyMetrics",method="postMethod_java.lang.Object_java.lang.String[]",mp_scope="base"} 1.0
 # TYPE REST_request_unmappedException_total counter

diff --git a/...al/src/main/java/org/eclipse/microprofile/metrics/test/optional/MpMetricOptionalTest.java b/...al/src/main/java/org/eclipse/microprofile/metrics/test/optional/MpMetricOptionalTest.java
@@ -52,7 +52,7 @@
 @RunWith(Arquillian.class)
 public class MpMetricOptionalTest {
 
-    private static final String PRPROM_APP_LABEL_REGEX = "mp_app=\"[-/A-Za-z0-9]+\"";
+    private static final String PROM_APP_LABEL_REGEX = "mp_app=\"[-/A-Za-z0-9]+\"";
 
     // context root under which the application JAX-RS resources are expected to be
     private static String contextRoot;
@@ -131,7 +131,7 @@ public class MpMetricOptionalTest {
     private static final int DEFAULT_PORT = 8080;
 
     private static String filterOutAppLabelOpenMetrics(String responseBody) {
-        return responseBody.replaceAll(PRPROM_APP_LABEL_REGEX, "").replaceAll("\\{,", "{").replaceAll(",\\}", "}");
+        return responseBody.replaceAll(PROM_APP_LABEL_REGEX, "").replaceAll("\\{,", "{").replaceAll(",\\}", "}");
     }
 
     @BeforeClass