Refactor bad smell UnnecessaryToStringCall

The toString() method is not needed in cases the underlying method handles the conversion. Also calling toString() on a String is redundant. Removing them simplifies the code.
eclipse · Jun 24, 2023 · 8ec366a · 8ec366a
1 parent 5abc5e8
commit 8ec366a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/...src/main/java/org/eclipse/microprofile/metrics/test/optional/MPMetricBaseMetricsTest.java b/...src/main/java/org/eclipse/microprofile/metrics/test/optional/MPMetricBaseMetricsTest.java
@@ -212,10 +212,10 @@ public void testBaseMetadataSingluarItemsPromMetrics() {
 
                 if (tmp[2].startsWith(promName)) {
                     found = true;
-                    assertEquals("Expected [" + mm.toString() + "] got [" + line + "]", tmp[3], mm.type);
+                    assertEquals("Expected [" + mm + "] got [" + line + "]", tmp[3], mm.type);
                 }
             }
-            assertTrue("Not found [" + mm.toString() + "]", found);
+            assertTrue("Not found [" + mm + "]", found);
 
         }
     }
@@ -425,3 +425,5 @@ public String toString() {
     }
 
 }
+
+
diff --git a/...l/src/main/java/org/eclipse/microprofile/metrics/test/optional/MetricAppBeanOptional.java b/...l/src/main/java/org/eclipse/microprofile/metrics/test/optional/MetricAppBeanOptional.java
@@ -194,7 +194,7 @@ public void getAsync(@Suspended final AsyncResponse asyncResponse) throws Except
                 Thread.sleep(5000);
                 asyncResponse.resume("This is a GET request with AsyncResponse");
             } catch (Exception e) {
-                System.err.println(e.toString());
+                System.err.println(e);
             }
         });
         thread.start();
@@ -250,3 +250,4 @@ public String postUnmappedArithException() throws Exception {
     }
 
 }
+