Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elapsedTime tracking to Timer metrics #524

Closed
donbourne opened this issue Jan 21, 2020 · 5 comments · Fixed by #552
Closed

Add elapsedTime tracking to Timer metrics #524

donbourne opened this issue Jan 21, 2020 · 5 comments · Fixed by #552
Assignees
Labels
api-breaking This marks an API breaking change
Milestone

Comments

@donbourne
Copy link
Member

see discussion in #496

@donbourne donbourne added this to the 3.0 milestone Jan 21, 2020
@Channyboy
Copy link
Contributor

Will need to be marked for 3.0.
The updated interface for Timer throws an error from the bnd-baseline-maven-plugin plugin.

@jmartisk
Copy link
Contributor

jmartisk commented Mar 5, 2020

@Channyboy isn't that because we need to update the bundle version in package-info.java files?
https://github.com/eclipse/microprofile-metrics/blob/2.4-M1/api/src/main/java/org/eclipse/microprofile/metrics/package-info.java
and
https://github.com/eclipse/microprofile-metrics/blob/2.4-M1/api/src/main/java/org/eclipse/microprofile/metrics/annotation/package-info.java

I think it will work then after changing them to 2.4. This is not a reason for doing a major version bump

@donbourne
Copy link
Member Author

I believe the problem is that if we add more methods to the Timer interface then any app-built implementations of Timer would break.

@jmartisk
Copy link
Contributor

jmartisk commented Mar 9, 2020

You're right it seems. We can go ahead with this only if we actually bump to 3.0.

@jmartisk
Copy link
Contributor

jmartisk commented Mar 9, 2020

Then I guess the same issue will be with #523
Perhaps we should consider doing a major bump after all, given the opportunity that we will have now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-breaking This marks an API breaking change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants