Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds elapsed time value to the Timer Metric #552

Merged
merged 3 commits into from Mar 27, 2020

Conversation

Channyboy
Copy link
Contributor

fixes #524

This PR is for MicroProfile Metrics3.0

Excluded from this PR is the updated values to 3.0-SNAPSHOT in all relevant pom.xml files.
It would be expected that the these values are already updated (either in another PR) or after the 2.4 has been released and the automated tools update the versions to 3.0-SNAPHSOT.

These values will need to be modified to properly build and test.

@Channyboy Channyboy added this to the 2.4/3.0 milestone Mar 17, 2020
Copy link
Contributor

@jmartisk jmartisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also have a TCK test for the OpenMetrics export of this,
perhaps updating MpMetricsTest#testApplicationTimerUnitOpenMetrics

@Channyboy Channyboy force-pushed the 524-TimerElapsed branch 4 times, most recently from 469d947 to f584186 Compare March 19, 2020 23:48
Copy link
Contributor

@jmartisk jmartisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Any concerns from @donbourne ?

@jmartisk
Copy link
Contributor

@Channyboy there's a conflict it seems, could you rebase please? I'd like to merge this soon

@Channyboy
Copy link
Contributor Author

@jmartisk rebased

Signed-off-by: David Chan <chdavid@ca.ibm.com>
Signed-off-by: David Chan <chdavid@ca.ibm.com>
Signed-off-by: David Chan <chdavid@ca.ibm.com>
@jmartisk jmartisk merged commit 7bc1514 into eclipse:master Mar 27, 2020
@Channyboy Channyboy deleted the 524-TimerElapsed branch July 23, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add elapsedTime tracking to Timer metrics
2 participants