Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in MicroProfile 6.0 javadoc generation #764

Closed
steven1046 opened this issue Jan 30, 2023 · 4 comments
Closed

Errors in MicroProfile 6.0 javadoc generation #764

steven1046 opened this issue Jan 30, 2023 · 4 comments
Assignees
Milestone

Comments

@steven1046
Copy link
Contributor

steven1046 commented Jan 30, 2023

I found 11 errors while using the javadoc command with the following java version:

openjdk 11.0.17 2022-10-18
IBM Semeru Runtime Open Edition 11.0.17.0 (build 11.0.17+8)

I got the source code from the respective links for MicroProfile 6.0 here: https://github.com/eclipse/microprofile/releases

Errors:

./org/eclipse/microprofile/metrics/Snapshot.java:57: error: reference not found
     * @return an array of {@link percentileValue}
     * 
 ./org/eclipse/microprofile/metrics/annotation/RegistryScope.java:51: error: reference not found
 * see {@link MetricRegistry.APPLICATION_SCOPE}, {@link MetricRegistry.BASE_SCOPE} and
              ^
./org/eclipse/microprofile/metrics/annotation/RegistryScope.java:51: error: reference not found
 * see {@link MetricRegistry.APPLICATION_SCOPE}, {@link MetricRegistry.BASE_SCOPE} and
                                                        ^
./org/eclipse/microprofile/metrics/annotation/RegistryScope.java:52: error: reference not found
 * {@link MetricRegistry.VENDOR_SCOPE}

./org/eclipse/microprofile/metrics/annotation/Counted.java:141: error: reference not found
     * @return The scope this counter belongs to. By default, the value is {@link MetricRegistry.APPLICATION_SCOPE}.
                                                                                  ^
Generating ../javadoc/org/eclipse/microprofile/metrics/annotation/Gauge.html...
./org/eclipse/microprofile/metrics/annotation/Gauge.java:115: error: reference not found
     * @return The scope this gauge belongs to. By default, the value is {@link MetricRegistry.APPLICATION_SCOPE}.
                                                                                ^
Generating ../javadoc/org/eclipse/microprofile/metrics/annotation/Metric.html...
./org/eclipse/microprofile/metrics/annotation/Metric.java:111: error: reference not found
     * @return The scope this metric belongs to. By default, the value is {@link MetricRegistry.APPLICATION_SCOPE}.
                                                                                 ^
Generating ../javadoc/org/eclipse/microprofile/metrics/annotation/RegistryScope.html...
./org/eclipse/microprofile/metrics/annotation/RegistryScope.java:68: error: reference not found
     *         see {@link MetricRegistry.APPLICATION_SCOPE}, {@link MetricRegistry.BASE_SCOPE} and
                          ^
./org/eclipse/microprofile/metrics/annotation/RegistryScope.java:68: error: reference not found
     *         see {@link MetricRegistry.APPLICATION_SCOPE}, {@link MetricRegistry.BASE_SCOPE} and
                                                                    ^
./org/eclipse/microprofile/metrics/annotation/RegistryScope.java:69: error: reference not found
     *         {@link MetricRegistry.VENDOR_SCOPE}

./org/eclipse/microprofile/metrics/annotation/Timed.java:135: error: reference not found
     * @return The scope this Timer belongs to. By default, the value is {@link MetricRegistry.APPLICATION_SCOPE}.

This is due to slightly invalid javadoc comment syntax.

@steven1046
Copy link
Contributor Author

steven1046 commented Jan 30, 2023

I will open a PR to fix these errors, i don't know how to assign myself to the issue.

@donbourne
Copy link
Member

hey @steven1046 , thanks for raising the issue... look forward to seeing your PR!

@steven1046
Copy link
Contributor Author

The above PR fixes 10 errors while i found 11 in my local testing. I did not find all 11 errors in the source code, so 1 must have already been fixed.

@Channyboy
Copy link
Contributor

Closing as PR was merged.

@Channyboy Channyboy added this to the 5.0.1 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants