Fixed 10 javadoc errors with MicroProfile 6.0 #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Fixes #764 |
|
build please |
|
@Channyboy, is there anything i need to do? I followed the instructions at https://github.com/eclipse/microprofile-metrics/blob/master/CONTRIBUTING.adoc. |
|
Oh, the |
|
@Channyboy , thank you for merging! Would this code eventually make it into the release here: https://github.com/eclipse/microprofile-metrics/releases/tag/5.0.0? |
|
Unfortunately, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were found while trying to generate MicroProfile 6.0 javadocs. The html was still produced, but some of the links did not work. The code changes will fix the links by changing the syntax in comments for what the javadoc command generates.
@link MetricRegistry.APPLICATION_SCOPEfor instance generates just text:This is fixed by changing it to ``@link MetricRegistry#APPLICATION_SCOPE` which generates a link:
