Update Histogram/Timer's Snapshot #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channyboy
commented
Aug 9, 2022
| public double get999thPercentile() { | ||
| return getValue(0.999); | ||
| } | ||
| public abstract long size(); |
There was a problem hiding this comment.
Use long instead of int to match up with micrometer.
Channyboy
commented
Aug 9, 2022
|
|
||
| /** | ||
| * Returns the highest value in the snapshot. | ||
| * | ||
| * @return the highest value | ||
| */ | ||
| public abstract long getMax(); | ||
| public abstract double getMax(); |
There was a problem hiding this comment.
use double to match up with micrometer
Channyboy
commented
Aug 9, 2022
| @@ -140,34 +141,72 @@ public void testSnapshotValues() throws Exception { | |||
| SAMPLE_LONG_DATA, histogramLong.getSnapshot().getValues()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testSnapshotPercentileValuesPresent() throws Exception { | |||
There was a problem hiding this comment.
not sure if we really need to test this?
There was a problem hiding this comment.
seems reasonable for this release, given those are the expected percentiles
Channyboy
commented
Aug 9, 2022
| @@ -154,56 +155,63 @@ public void testSnapshotValues() throws Exception { | |||
| SAMPLE_LONG_DATA, globalTimer.getSnapshot().getValues()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testSnapshotPercentileValuesPresent() throws Exception { | |||
|
|
|||
There was a problem hiding this comment.
not sure if we really need to test this?
Channyboy
force-pushed
the
695-696-snapshot
branch
from
bc40f0c
to
d5550ad
Compare
- Removed getMedian, getXXXPercentile, getMin, getStdDev, getValues from Snapshot - Added inner static class PercentileValue to Snapshot, percentileValues() method to Snapshot - Spec updates - TCK updates
Channyboy
force-pushed
the
695-696-snapshot
branch
from
d5550ad
to
2a493ab
Compare
Channyboy
commented
Aug 9, 2022
donbourne
requested changes
Aug 9, 2022
| @@ -140,34 +141,72 @@ public void testSnapshotValues() throws Exception { | |||
| SAMPLE_LONG_DATA, histogramLong.getSnapshot().getValues()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testSnapshotPercentileValuesPresent() throws Exception { | |||
There was a problem hiding this comment.
seems reasonable for this release, given those are the expected percentiles
Channyboy
changed the title
donbourne
requested changes
Aug 11, 2022
tck/api/src/main/java/org/eclipse/microprofile/metrics/tck/metrics/HistogramTest.java
Show resolved
Hide resolved
tck/api/src/main/java/org/eclipse/microprofile/metrics/tck/metrics/HistogramTest.java
Outdated
Show resolved
Hide resolved
jgallimore
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Snapshot used by Histogram and Timer
^methods removed were those that can not be supported by micrometer
fixes #695
fixes #696