-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #735, remove MetricType class #740
Conversation
Signed-off-by: Jonathan Gallimore <jgallimore@tomitribe.com>
Can one of the admins verify this patch? |
Signed-off-by: Jonathan Gallimore <jgallimore@tomitribe.com>
@@ -547,7 +547,6 @@ The object can be built via a `MetadataBuilder` with a fluent API. | |||
Metadata m = Metadata.builder() | |||
.withName("myMeter") | |||
.withDescription("Example meter") | |||
.withType(MetricType.METER) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also lines 443-448 of this file, that discuss metric type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @donbourne I've pushed a further update, and also updated the changes in 5.0 section.
…es, and updated the change list Signed-off-by: Jonathan Gallimore <jgallimore@tomitribe.com>
ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Jonathan Gallimore jgallimore@tomitribe.com