Update multi-app section to recommend usage of mp.metrics.defaultAppName
#777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channyboy
force-pushed
the
766-defaultAppName
branch
from
4262150
to
9b0b3e0
Compare
donbourne
reviewed
Jul 14, 2023
donbourne
reviewed
Aug 13, 2023
donbourne
reviewed
Aug 15, 2023
donbourne
reviewed
Aug 15, 2023
donbourne
reviewed
Aug 15, 2023
| and setting a custom value for the property `mp.metrics.appName` inside it. | ||
| The value of the `mp_app` tag should be passed by the application server to the application via a MicroProfile Config property named `mp.metrics.appName`. The property is to be defined at the application level through the `META-INF/microprofile-config.properties` file within the application archive. The value of the property will be used for the `mp_app` tag for metrics that originate from the application. | ||
|
|
||
| Due to the restriction imposed on metrics of the same-name to contain the same set of tag names. A conflict for metric registration may occur for runtimes that support _vendor_ metrics that can originate from both a server context and an application context. For example, a vendor implementation that provides servlet metrics could track servlet requests to the application(s) and to the server. However, the servlet metrics that track requests to the application may originate from the application-context and may include the `mp_app` tag. This will cause a mismatched set of tags compared to the servlet metrics that originate from the server-context. |
There was a problem hiding this comment.
Due to the restriction imposed on metrics of the same-name to contain the same set of tag names. A conflict for metric registration may occur for runtimes that support vendor metrics that can originate from both a server context and an application context.
->
As metrics of the same-name must contain the same set of tag names, a conflict for metric registration may occur for runtimes that support vendor metrics that can originate from both a server context and an application context.
… apply comments and suggestions from review
Channyboy
force-pushed
the
766-defaultAppName
branch
from
90a2b3b
to
2c917b7
Compare
donbourne
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #766