Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameters annotation should only target the method #340

Closed
arthurdm opened this issue Mar 18, 2019 · 3 comments
Closed

Parameters annotation should only target the method #340

arthurdm opened this issue Mar 18, 2019 · 3 comments
Labels
2.0 candidate incompatible-changes This marks an API breaking change
Milestone
MP OpenAPI 2.0

Comments

@arthurdm
Copy link
Member

Current our Parameters annotation has two targets: method and parameter.

@arturdzm brought up a good point that it should only have the method target. Otherwise, if we associate @Parameters with a single parameter, we're associating multiple parameters with a single one..which doesn't make much sense.
@arthurdm arthurdm mentioned this issue May 21, 2019
Closed
@Rachelwrq Rachelwrq mentioned this issue May 23, 2019
Merged
@MikeEdgar MikeEdgar mentioned this issue Jun 15, 2019
Closed
@arthurdm
Copy link
Member Author

PR #352 has completed the development work piece of this issue. However, we're still missing the corresponding TCK update. At the moment the TCK should not complile.

@Rachelwrq Rachelwrq mentioned this issue Jun 17, 2019
Merged
@EricWittmann
Copy link
Contributor

@arthurdm This seems complete now with #358 ?

@arthurdm
Copy link
Member Author

agreed. closing.

@arthurdm arthurdm added this to the MP OpenAPI 2.0 milestone Apr 14, 2020
@jmini jmini added the incompatible-changes This marks an API breaking change label Jul 12, 2020
Azquelt pushed a commit to Azquelt/microprofile-open-api that referenced this issue Mar 17, 2022
@phillip-kruger
Merge pull request eclipse#340 from smallrye/release-2.0.0
40f6618 
release 2.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0 candidate incompatible-changes This marks an API breaking change
Projects
None yet
Milestone
MP OpenAPI 2.0
Development

No branches or pull requests
3 participants
@jmini @EricWittmann @arthurdm