TestNG 7.4.0 Assert.assertNotSame has a bug which causes ModelConstructionTest TCK to fail

[tevans78]

assertNotSame ought to assert that two objects are not the same (==) but in version 7.4.0 of TestNG it tests if they are equal. This can cause a TCK failure where two object are expected to be different instances even though they are equal. The tests that fail for me are

• ModelConstructionTest.openAPITest
• ModelConstructionTest.operationTest
• ModelConstructionTest.securityRequirementTest
  These all use ModelConstructionTest.createConstructibleInstance which uses Assert.assertNotSame
  

  microprofile-open-api/tck/src/main/java/org/eclipse/microprofile/openapi/tck/ModelConstructionTest.java

  Line 1379 in d768dbe

  assertNotSame(o2, o1, "OASFactory.createObject(" + clazz.getName()

The bug was reported multiple times in TestNG and has been fixed but is not yet in a released version.
testng-team/testng#2486
testng-team/testng#2616

Although this issue has been found in the MP OpenAPI TCK, it may be a problem across the whole of MicroProfile 5.0, where the TestNG version is 7.4.0. I suggest that for now the MicroProfile TCKs should avoid use of Assert.assertNotSame.