Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error #252

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Fix compile error #252

merged 1 commit into from
Aug 14, 2018

Conversation

jmini
Copy link
Contributor

@jmini jmini commented Aug 12, 2018

My PR #250 creates following compile error in the TCK project:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project microprofile-openapi-tck: Compilation failure: Compilation failure: 
[ERROR] /___/microprofile-open-api/tck/src/main/java/org/eclipse/microprofile/openapi/tck/OASFactoryErrorTest.java:[35,17] error: OASFactoryErrorTest.MyLicenseImpl is not abstract and does not override abstract method addExtension(String,Object) in Extensible
[ERROR] /___/microprofile-open-api/tck/src/main/java/org/eclipse/microprofile/openapi/tck/OASFactoryErrorTest.java:[41,20] error: addExtension(String,Object) in OASFactoryErrorTest.MyLicenseImpl cannot implement addExtension(String,Object) in Extensible
[ERROR] 
[ERROR]     T extends Extensible<T> declared in interface Extensible
[ERROR] /___/microprofile-open-api/tck/src/main/java/org/eclipse/microprofile/openapi/tck/OASFactoryErrorTest.java:[40,8] error: method does not override or implement a method from a supertype
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :microprofile-openapi-tck

I am really sorry about it. I think this was created because I did not use clean while using maven locally.

Signed-off-by: Jeremie Bresson <dev@jmini.fr>
Copy link
Member

@arthurdm arthurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jmini - looks good to me

@arthurdm arthurdm merged commit 844ede3 into eclipse:master Aug 14, 2018
@jmini
Copy link
Contributor Author

jmini commented Aug 14, 2018

FYI: I have opened #253 to discuss CI possibilities

Azquelt pushed a commit to Azquelt/microprofile-open-api that referenced this pull request Mar 17, 2022
Added an option to disable processing of @ApplicationPath.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants