Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax TCK to allow implementations to create a copy of maps/lists #286

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

jmini
Copy link
Contributor

@jmini jmini commented Oct 13, 2018

See description in issue #284

For 1.1:

If implementation would like to create a copy of maps and list in their setters, then the tests should stay green.

This PR changes same-instance-checks into equals-checks in order to compare list/map content instead of having the same instance.

See eclipse#284

Signed-off-by: Jeremie Bresson <dev@jmini.fr>
Copy link
Member

@arthurdm arthurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @jmini

@arthurdm arthurdm merged commit 14590bc into eclipse:master Oct 15, 2018
Azquelt pushed a commit to Azquelt/microprofile-open-api that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants