New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RequestBodySchema and APIResponseSchema annotations #410
Add RequestBodySchema and APIResponseSchema annotations #410
Conversation
7988a6c
to
8a5210c
Compare
We discussed in the hangout that the documentation for the response annotation will be updated to specify how implementations should derive the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update - I'm working on TCK tests for these annotations as well. Those can be part of this PR or a separate issue - either way is fine with me. |
I have no preference either - whatever is easier for you I would say. |
Signed-off-by: Michael Edgar <michael@xlate.io>
Signed-off-by: Michael Edgar <michael@xlate.io>
Signed-off-by: Michael Edgar <michael@xlate.io>
2007265
to
f58206e
Compare
Signed-off-by: Michael Edgar <michael@xlate.io>
This branch was re-based and the last two commits with the TCK tests were added. @EricWittmann , @arthurdm - I think this is ready to go now. Please let me know if you have any feedback. |
@arthurdm - have you had a chance to review? Please let me know if you notice any issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay, look great @MikeEdgar , thanks!
release 2.0.4
Fixes #363
The changes here are the latest mentioned in #363, with one difference being that the
responseDescription
property of@APIResponseSchema
is not defaulted to an empty string. This seems appropriate given the JavaDoc of@APIResponse#description()
:@EricWittmann @arthurdm - this can be discussed in the next hangout or here.
Signed-off-by: Michael Edgar michael@xlate.io