Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinguish resources paths in airlines app, by username and id #559

Merged

Conversation

aubi
Copy link
Contributor

@aubi aubi commented Mar 17, 2023

In the original version, the testing apps cannot deploy to an application server (Payara in my case), as the paths '/user/{username}' and '/user/{id}' are ambiguous.

According to the reaction in the issue #557, I tried to suggest a fix.

In the original version, the testing apps cannot deploy, as the
paths '/user/{username}' and '/user/{id}' are ambiguous.
@eclipse-microprofile-bot
Copy link
Contributor

Can one of the admins verify this patch?

@MikeEdgar MikeEdgar linked an issue Mar 18, 2023 that may be closed by this pull request
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @Azquelt , any concerns?

@Azquelt
Copy link
Member

Azquelt commented Mar 30, 2023

Sorry for the slow reply, I was on vacation.

No concerns from me. The changes look good and I ran the TCK with this change against OpenLiberty and it still passed.

@MikeEdgar MikeEdgar merged commit 66d8144 into eclipse:master Apr 13, 2023
3 checks passed
@aubi aubi deleted the separate-airline-users-paths-upstream branch June 28, 2023 19:06
This was referenced Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Ambiguous Resource Methods in TCK, airlines UserResource
4 participants