Move OASFactoryResolver to SPI module, bump version to 4.0-SNAPSHOT #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8bb9a44.
Signed-off-by: Michael Edgar <michael@xlate.io>
MikeEdgar
commented
Jan 20, 2024
| @@ -55,7 +48,7 @@ public abstract class OASFactoryResolver { | |||
| * @throws IllegalArgumentException | |||
| * if an instance could not be created, most likely, due to an illegal or inappropriate class | |||
| */ | |||
| public abstract <T extends Constructible> T createObject(Class<T> clazz); | |||
| public abstract <T> T createObject(Class<T> clazz); | |||
There was a problem hiding this comment.
Dropped extends Constructible to avoid dependency cycle with api module.
There was a problem hiding this comment.
Implementations should already be checking that T is Constructible and the API used by applications in OASFactory retains the Constructible type on createObject.
There was a problem hiding this comment.
As mentioned in #576 , this is not a great solution as it breaks compatibility with previous versions and also makes the SPI contract too loose.
| @@ -20,7 +20,7 @@ | |||
| <!-- This is just for now and will not work if the API has a separate release cycle than the rest. --> | |||
| <groupId>org.eclipse.microprofile.openapi</groupId> | |||
| <artifactId>microprofile-openapi-parent</artifactId> | |||
| <version>3.2-SNAPSHOT</version> | |||
| <version>4.0-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Module version bump required to pass biz.aQute.bnd:bnd-baseline-maven-plugin verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #576