Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test methods setDefaultValue and getDefaultValue #605

Closed
wants to merge 1 commit into from
Closed

test methods setDefaultValue and getDefaultValue #605

wants to merge 1 commit into from

Conversation

benjamin-confino
Copy link
Contributor

When I did the audit for #593 I noticed we don't test setDefaultValue or getDefaultValue so I added a quick check in serverVariableTest

@eclipse-microprofile-bot
Copy link
Contributor

Can one of the admins verify this patch?

@Azquelt
Copy link
Member

Azquelt commented May 1, 2024

I don't think this is needed. processConstructible called at the start of this method should reflectively test all simple getters and setters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjamin-confino @eclipse-microprofile-bot @Azquelt