Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ref with description and summary #618

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

Azquelt
Copy link
Member

@Azquelt Azquelt commented May 16, 2024

$ref is now allowed alongside description and summary.

  • Update model and annotation javadoc accordingly.
  • Test model
  • Test annotations

Resolves #589

Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor fix for the Link JavaDoc

$ref is now allowed alongside description and summary.

- Update model and annotation javadoc accordingly.
- Test model
- Test annotations
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@MikeEdgar MikeEdgar merged commit 27b4cc2 into eclipse:main Jun 4, 2024
4 checks passed
@Azquelt Azquelt deleted the ref-description-summary branch June 5, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OAS 3.1.0] Summary and description now valid when $ref is set
2 participants