-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test apps with no paths #625
Conversation
Can one of the admins verify this patch? |
...c/main/java/org/eclipse/microprofile/openapi/reader/MyOASModelReaderForJustComponentApp.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/microprofile/openapi/reader/MyOASModelReaderForJustWebHookApp.java
Outdated
Show resolved
Hide resolved
14a5b0c
to
11da26d
Compare
...src/main/java/org/eclipse/microprofile/openapi/reader/MyOASModelReaderForJustWebHookApp.java
Outdated
Show resolved
Hide resolved
11da26d
to
e74df60
Compare
@Test(dataProvider = "formatProvider") | ||
public void testDocumentCreated(String type) { | ||
ValidatableResponse vr = callEndpoint(type); | ||
vr.body("webhooks.blackMarketEvent.get.summary", equalTo("Notifies that a illicit deal has been done")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this pass? It looks like it ought to fail. If it is passing then I'm even more worried.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good news, it needed fixing to pass.
.addAsManifestResource("microprofile-reader-just-component.properties", | ||
"microprofile-config.properties"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is actually putting the properties file in the wrong place, but the existing tests are also wrong, so I'll raise a new issue for that.
e74df60
to
d1a6ea8
Compare
fixes #592
No changes to smallrye were required to pass these tests.