Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error tag for failed client requests #114

Open
pavolloffay opened this issue Oct 23, 2018 · 1 comment
Open

Error tag for failed client requests #114

pavolloffay opened this issue Oct 23, 2018 · 1 comment

Comments

@pavolloffay
Copy link
Member

from the spec:

Tags.ERROR tag SHOULD be added to a Span on failed operations for any client error (4xx) codes.
If there is an exception object available the implementation SHOULD also add logs event=error and error.object=<error object instance> to the active span.

however if the server returns 5xx it can be also considered as a failed operation. We could consider adding error tag to client spans for status code >= 4xx.

@tonyreigns
Copy link

For the Liberty implementation, this is currently how we handle both 4xx and 5xx errors. We add all error codes >= 4xx to spans on failed operations. This would be a good addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants