Add return MIME type #145
Merged
Add return MIME type #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Wong <fmhwong@ca.ibm.com>
fmhwong
force-pushed
the
144-addMINEType
branch
from
2c22e4e
to
e989688
Compare
|
@pavolloffay Please review. |
pavolloffay
approved these changes
Feb 14, 2019
|
There is typo MINE -> MIME (https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types) and this propagates into changelog of 1.3.1 release https://github.com/eclipse/microprofile-opentracing/releases/ |
|
Thanks, I have created #154 to fix it in the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add return MINE type to interfaces. Fixes #144