Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP method to http-path operation name #125

Merged

Conversation

pavolloffay
Copy link
Member

Resolves #111

Signed-off-by: Pavol Loffay ploffay@redhat.com

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
if the class is annotated with `@Path(service)` and method `@Path(endpoint)` then the operation name is `/service/endpoint`.
* `http-path` - the operation name has the following form
`<HTTP method>:<@Path value of endpoint's class>/<@Path value of endpoint's method>`.
For example if the class is annotated with `@Path(service)` and method `Path@(endpoint)` then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo Path@(endpoint)

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay
Copy link
Member Author

@fmhwong typo fixed, could you please re-review/approve?

Copy link
Contributor

@fmhwong fmhwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavolloffay pavolloffay merged commit 39d6955 into eclipse:master Nov 2, 2018
@pavolloffay pavolloffay mentioned this pull request Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants