Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP method to http-path operation name #125

Merged

Conversation

Projects
None yet
2 participants
@pavolloffay
Copy link
Member

commented Nov 2, 2018

Resolves #111

Signed-off-by: Pavol Loffay ploffay@redhat.com

Add HTTP method to http-path operation name
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
if the class is annotated with `@Path(service)` and method `@Path(endpoint)` then the operation name is `/service/endpoint`.
* `http-path` - the operation name has the following form
`<HTTP method>:<@Path value of endpoint's class>/<@Path value of endpoint's method>`.
For example if the class is annotated with `@Path(service)` and method `Path@(endpoint)` then

This comment has been minimized.

Copy link
@fmhwong

fmhwong Nov 2, 2018

Contributor

typo Path@(endpoint)

Fix review comments
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2018

@fmhwong typo fixed, could you please re-review/approve?

@fmhwong

fmhwong approved these changes Nov 2, 2018

Copy link
Contributor

left a comment

LGTM

@pavolloffay pavolloffay merged commit 39d6955 into eclipse:master Nov 2, 2018

@pavolloffay pavolloffay referenced this pull request Nov 9, 2018

Merged

Update changelog #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.