Clarify default value when skip pattern is defined #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Wong <fmhwong@ca.ibm.com>
pavolloffay
reviewed
Nov 2, 2018
| @@ -192,7 +192,7 @@ server endpoint. | |||
| The skip pattern is specified as a string with key `mp.opentracing.server.skip-pattern` which has to be | |||
| compliant with `java.util.regex.Pattern`. An example skip pattern might be `mp.opentracing.server.skip-pattern=/health|/metrics.*` | |||
|
|
|||
| The default value of the skip pattern excludes tracing for default endpoints defined by MicroProfile Health, Metrics and OpenAPI specification. | |||
| The default value of the skip pattern excludes tracing for default endpoints defined by MicroProfile Health, Metrics and OpenAPI specification. Defining a skip pattern does not override the default value. Instead, both skip pattern and the default value are combined. | |||
There was a problem hiding this comment.
I think we should rephrase it completely and instead just say that endpoits exposed by Metrics, Health.. are not traced.
There was a problem hiding this comment.
@pavolloffay Revised the wording. Please review again. Thanks!
Signed-off-by: Felix Wong <fmhwong@ca.ibm.com>
Signed-off-by: Felix Wong <fmhwong@ca.ibm.com>
Signed-off-by: Felix Wong <fmhwong@ca.ibm.com>
This reverts commit 901cd78.
pavolloffay
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
Signed-off-by: Felix Wong fmhwong@ca.ibm.com