Add support for skip pattern #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
commented
Aug 31, 2018
| /** | ||
| * @author Pavol Loffay | ||
| */ | ||
| public class OpenTracingBaseTests extends Arquillian { |
There was a problem hiding this comment.
The OpentracingClientTests is quite big I have introduced this base class with some common methods. Different features can be tested in separate test classes.
|
@pilhuhn @fmhwong @objectiser could you please review? |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
objectiser
approved these changes
Aug 31, 2018
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
|
thanks @objectiser, I have changed year in license headers in new files to 2018. There is a license check and it was passing even with 2017 so I guess it's fine. |
pavolloffay
commented
Aug 31, 2018
| @@ -74,50 +55,7 @@ | |||
| * Opentracing TCK tests. | |||
| * @author <a href="mailto:steve.m.fontes@gmail.com">Steve Fontes</a> | |||
| */ | |||
| public class OpentracingClientTests extends Arquillian { | |||
There was a problem hiding this comment.
I have renamed it to OpenTracing
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #16
Example implementation: smallrye/smallrye-opentracing#23. The implementation itself is in https://github.com/opentracing-contrib/java-jaxrs/blob/master/opentracing-jaxrs2/src/main/java/io/opentracing/contrib/jaxrs2/server/ServerTracingFilter.java#L128
Signed-off-by: Pavol Loffay ploffay@redhat.com